Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2837283004: PPC/s390: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. (Closed)

Created:
3 years, 8 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [stubs] Drop CallApiCallbackStub::call_data_undefined optimization. Port 46d0e4818a361b3fb535e1c78973b4d1ace000dc Original Commit Message: The CallApiCallbackStub can avoid loading undefined in case the call_data is already undefined, which doubles the number of versions of the stub and adds unnecessary complexity (at the benefit of saving one stupid load). The idea is to turn the CallApiCallbackStub into a single builtin instead, which does the right thing, so this is the first step towards that goal. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:6304 LOG=N Review-Url: https://codereview.chromium.org/2837283004 Cr-Commit-Position: refs/heads/master@{#44872} Committed: https://chromium.googlesource.com/v8/v8/+/336876989a50112d9012802fd824d57d39bcf8ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M src/ic/ppc/handler-compiler-ppc.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 2 chunks +1 line, -4 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 8 months ago (2017-04-25 21:09:41 UTC) #1
john.yan
lgtm
3 years, 8 months ago (2017-04-25 21:10:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837283004/1
3 years, 8 months ago (2017-04-25 21:11:11 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 21:37:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/336876989a50112d9012802fd824d57d39b...

Powered by Google App Engine
This is Rietveld 408576698