ShapeDetection: use makeNonTextureImage() to support texture-backed sources

ShapeDetection: use makeNonTextureImage() to support texture-backed sources

In certain cases (as reported in the bug) the SkImage used for detection
happens to be texture-backed.  This CL uses makeNonTextureImage()
which solves this problem while doing nothing when the SkImage is not
texture backed (i.e. is raster).

BUG=714927
Review-Url: https://codereview.chromium.org/2837273003
Cr-Commit-Position: refs/heads/master@{#467192}
Committed: https://chromium.googlesource.com/chromium/src/+/d7d447a09a95eb7ad399eb8512f677a66e127d69

[mcasas, 2017-04-25 21:59:13]

Description was changed from

==========
ShapeDetection: use makeNonTextureImage() to support texture-backed sources

Using makeNonTextureImage()

BUG=714927
==========

to

==========
ShapeDetection: use makeNonTextureImage() to support texture-backed sources

In certain cases (as reported in the bug) the SkImage used for detection
happens to be texture-backed.  This CL uses makeNonTextureImage()
which solves this problem while doing nothing when the SkImage is not
texture backed (i.e. is raster).

BUG=714927
==========

[mcasas, 2017-04-25 21:59:38]

mcasas@chromium.org changed reviewers:
+ emircan@chromium.org

[mcasas, 2017-04-25 21:59:38]

emircan@  tiny CL, PTAL

[emircan, 2017-04-25 22:27:59]

lgtm

[mcasas, 2017-04-25 22:57:35]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 22:58:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emircan, 2017-04-25 23:02:13]

On 2017/04/25 22:27:59, emircan wrote:
> lgtm

After offline discussion ps#2 lgtm. Using makeNonTextureImage() eliminates that
elseif case.

[mcasas, 2017-04-26 00:36:54]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-04-26 00:37:00]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-04-26 00:37:17]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 01:17:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493167020624170,
"parent_rev": "4eeacf4f4fa0bbfffb04f81d113875f044ac5141", "commit_rev":
"d7d447a09a95eb7ad399eb8512f677a66e127d69"}

[commit-bot: I haz the power, 2017-04-26 01:18:27]

Description was changed from

==========
ShapeDetection: use makeNonTextureImage() to support texture-backed sources

In certain cases (as reported in the bug) the SkImage used for detection
happens to be texture-backed.  This CL uses makeNonTextureImage()
which solves this problem while doing nothing when the SkImage is not
texture backed (i.e. is raster).

BUG=714927
==========

to

==========
ShapeDetection: use makeNonTextureImage() to support texture-backed sources

In certain cases (as reported in the bug) the SkImage used for detection
happens to be texture-backed.  This CL uses makeNonTextureImage()
which solves this problem while doing nothing when the SkImage is not
texture backed (i.e. is raster).

BUG=714927

Review-Url: https://codereview.chromium.org/2837273003
Cr-Commit-Position: refs/heads/master@{#467192}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7d447a09a95eb7ad399eb8512f6...
==========

[commit-bot: I haz the power, 2017-04-26 01:18:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d7d447a09a95eb7ad399eb8512f6...