Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2837273002: Mark LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange() as const member function (Closed)

Created:
3 years, 8 months ago by yosin_UTC9
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, tanvir, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Mark LayoutText::AbsoluteRectsForRange() and AbsoluteQuadsForRange() as const member function This patch marks |AbsoluteRectsForRange()| and |AbsoluteQuadsForRange()| in |LayoutText| as const member function since these function don't modify member variables and don't call non-const member functions. This patch is a preparation of patch[1]. [1] http://crrev.com/2839633002: Introduce ComputeTextBounds template in Range.cpp BUG=691198 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2837273002 Cr-Commit-Position: refs/heads/master@{#466925} Committed: https://chromium.googlesource.com/chromium/src/+/a3bf55ce6853e03b407fb255a8101b0731cd529a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutText.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutText.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yosin_UTC9
PTAL
3 years, 8 months ago (2017-04-25 06:51:37 UTC) #6
tkent
lgtm
3 years, 8 months ago (2017-04-25 08:25:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837273002/1
3 years, 8 months ago (2017-04-25 08:25:35 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:30:47 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a3bf55ce6853e03b407fb255a810...

Powered by Google App Engine
This is Rietveld 408576698