Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Issue 2837253002: [ES6 modules] Rethrow instantiation error when attempt to resolve instantiation failed module. (Closed)

Created:
3 years, 8 months ago by kouhei (in TOK)
Modified:
3 years, 7 months ago
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ES6 modules] Rethrow instantiation error when attempt to resolve instantiation failed module. This CL resolves TODO(kouhei) in ScriptModuleResolverImpl to rethrow instantiation error when resolved module has failed to instantiate. TEST=ScriptModuleResolverImplTest.ResolveInstantiationFailedModule BUG=594639 Review-Url: https://codereview.chromium.org/2837253002 Cr-Commit-Position: refs/heads/master@{#468275} Committed: https://chromium.googlesource.com/chromium/src/+/40a4cdf946305d99ce988d67b17602454b01c1a3

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -17 lines) Patch
M third_party/WebKit/Source/core/dom/ModuleScript.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImpl.cpp View 1 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptModuleResolverImplTest.cpp View 1 9 chunks +56 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
kouhei (in TOK)
3 years, 8 months ago (2017-04-25 03:53:17 UTC) #2
yhirano
lgtm
3 years, 8 months ago (2017-04-25 10:33:08 UTC) #7
hiroshige
lgtm
3 years, 7 months ago (2017-04-27 22:40:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837253002/1
3 years, 7 months ago (2017-04-28 04:08:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/257244) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-04-28 04:12:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837253002/20001
3 years, 7 months ago (2017-05-01 01:50:28 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 03:39:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/40a4cdf946305d99ce988d67b176...

Powered by Google App Engine
This is Rietveld 408576698