Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Issue 2837203002: [DevTools] Move dom breakpoints to DOMDebuggerModel (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move dom breakpoints to DOMDebuggerModel DOMBreakpointsSidebarPane just renders dom breakpoints now. Removed pane's proxy and moved context menu into it. The pane should not be referenced outside of components anymore. BUG=none Review-Url: https://codereview.chromium.org/2837203002 Cr-Commit-Position: refs/heads/master@{#467121} Committed: https://chromium.googlesource.com/chromium/src/+/fbf6b2dedcd7bd30dd82cdfd768ee5279d309721

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed review comments #

Messages

Total messages: 15 (10 generated)
dgozman
Could you please take a look?
3 years, 7 months ago (2017-04-24 23:28:35 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/2837203002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js File third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js (right): https://codereview.chromium.org/2837203002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js#newcode210 third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js:210: constructor(domDebuggerModel, node, type, enabled) { Hi Java! This ...
3 years, 7 months ago (2017-04-24 23:46:20 UTC) #6
dgozman
https://codereview.chromium.org/2837203002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js File third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js (right): https://codereview.chromium.org/2837203002/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js#newcode210 third_party/WebKit/Source/devtools/front_end/sdk/DOMDebuggerModel.js:210: constructor(domDebuggerModel, node, type, enabled) { On 2017/04/24 23:46:20, pfeldman ...
3 years, 7 months ago (2017-04-25 19:24:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837203002/20001
3 years, 7 months ago (2017-04-25 19:25:54 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 21:37:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fbf6b2dedcd7bd30dd82cdfd768e...

Powered by Google App Engine
This is Rietveld 408576698