Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2837183002: [SPv2] Apply effects before clips for when the effect does not move pixels (Closed)

Created:
3 years, 8 months ago by chrishtr
Modified:
3 years, 8 months ago
Reviewers:
trchen
CC:
ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPv2] Apply effects before clips for when the effect does not move pixels In such cases, the clip and effect commute, so we have the option to apply them in either order. BUG=699834 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2837183002 Cr-Commit-Position: refs/heads/master@{#467134} Committed: https://chromium.googlesource.com/chromium/src/+/930a3adf239219b1606b8cbca691f9130fb466ca

Patch Set 1 #

Patch Set 2 : none #

Patch Set 3 : none #

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -17 lines) Patch
M third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PropertyTreeStateTest.cpp View 1 2 3 5 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
chrishtr
3 years, 8 months ago (2017-04-25 00:09:40 UTC) #6
trchen
lgtm
3 years, 8 months ago (2017-04-25 21:42:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837183002/60001
3 years, 8 months ago (2017-04-25 22:09:30 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 22:15:01 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/930a3adf239219b1606b8cbca691...

Powered by Google App Engine
This is Rietveld 408576698