Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2837123005: Cookies disabled for DeviceManagementService. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cookies disabled for DeviceManagementService. Following discussion in https://codereview.chromium.org/2800653002, cookies are disabled for network request of: components/policy/core/common/cloud/device_management_service.cc BUG= Review-Url: https://codereview.chromium.org/2837123005 Cr-Commit-Position: refs/heads/master@{#467280} Committed: https://chromium.googlesource.com/chromium/src/+/136356dc7ed7b595ed2e0b63d968a7a27171468c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/policy/core/common/cloud/device_management_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Ramin Halavati
Following discussion in https://codereview.chromium.org/2800653002, I've disabled cookies for network request of DeviceManagementService. Please review.
3 years, 8 months ago (2017-04-26 06:20:31 UTC) #6
Andrew T Wilson (Slow)
lgtm
3 years, 8 months ago (2017-04-26 09:24:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837123005/1
3 years, 8 months ago (2017-04-26 09:24:47 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 09:29:51 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/136356dc7ed7b595ed2e0b63d968...

Powered by Google App Engine
This is Rietveld 408576698