Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2837113002: Remove unneeded WebKit enum forward declarations (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 8 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded WebKit enum forward declarations Forward declaring of enums without specifying a type is illegal. These forward declarations only worked because they weren't needed. They were found by VC++'s overzealous C4471 warning. R=chrishtr@chromium.org Review-Url: https://codereview.chromium.org/2837113002 Cr-Commit-Position: refs/heads/master@{#466789} Committed: https://chromium.googlesource.com/chromium/src/+/b882d76143eaa993f8f1d0c6393d4d52d836838e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/layout/api/LineLayoutItem.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebSharedWorkerRepositoryClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
brucedawson
Simple code cleanup. PTAL.
3 years, 8 months ago (2017-04-24 20:53:43 UTC) #4
chrishtr
lgtm
3 years, 8 months ago (2017-04-24 22:05:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837113002/1
3 years, 8 months ago (2017-04-24 22:06:10 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:10:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b882d76143eaa993f8f1d0c6393d...

Powered by Google App Engine
This is Rietveld 408576698