Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2837093003: Revert of Add --headless flag to Windows (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add --headless flag to Windows (patchset #29 id:560001 of https://codereview.chromium.org/2762593002/ ) Reason for revert: Testing revert on --headless flag, due to increase in child_dll size: https://bugs.chromium.org/p/chromium/issues/detail?id=714841 Original issue's description: > Launch bug: https://bugs.chromium.org/p/chromium/issues/detail?id=705916 > > Add --headless flag to Windows: > > Fix browser_tests not compiling properly on windows > Fix headless/BUILD.gn by: > - Changing headless_lib to a headless component, following steps in https://chromium.googlesource.com/chromium/src/+/master/docs/component_build.md and fixing the build for linux, since it now compiles as a shared_library when component build is true. > - Adding neccesary HEADLESS_EXPORT (submitted in https://codereview.chromium.org/2775693003/) > - Disabling breakpad in windows (will fix in a separate CL) > > > BUG=686608 > > Review-Url: https://codereview.chromium.org/2762593002 > Cr-Original-Commit-Position: refs/heads/master@{#466176} > Committed: https://chromium.googlesource.com/chromium/src/+/e3c745d4b37a659afaa0358c7de7b9bc881decb5 > Review-Url: https://codereview.chromium.org/2762593002 > Cr-Commit-Position: refs/heads/master@{#466259} > Committed: https://chromium.googlesource.com/chromium/src/+/d238dae172d63175b562f99fc988e47e5213a244 TBR=alexclarke@chromium.org,sky@chromium.org,skyostil@chromium.org,wfh@chromium.org,jzfeng@chromium.org,nick@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=686608 Review-Url: https://codereview.chromium.org/2837093003 Cr-Commit-Position: refs/heads/master@{#466871} Committed: https://chromium.googlesource.com/chromium/src/+/4c5022c615824a6e2ad67db5eec5a093e3111e2d

Patch Set 1 #

Patch Set 2 : Manual rebase #

Patch Set 3 : Fix compilation issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -280 lines) Patch
M chrome/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/app/chrome_main.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M headless/BUILD.gn View 1 10 chunks +28 lines, -119 lines 0 comments Download
M headless/DEPS View 1 2 chunks +0 lines, -2 lines 0 comments Download
M headless/app/headless_example.cc View 1 3 chunks +0 lines, -15 lines 0 comments Download
M headless/app/headless_shell.h View 1 1 chunk +1 line, -1 line 0 comments Download
M headless/app/headless_shell.cc View 1 6 chunks +4 lines, -26 lines 0 comments Download
M headless/app/headless_shell_main.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M headless/app/headless_shell_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M headless/app/headless_shell_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M headless/lib/browser/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 1 5 chunks +8 lines, -6 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 1 3 chunks +4 lines, -4 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 1 2 4 chunks +4 lines, -13 lines 0 comments Download
M headless/public/headless_browser.h View 1 7 chunks +4 lines, -22 lines 0 comments Download
M headless/public/headless_browser.cc View 1 3 chunks +0 lines, -20 lines 0 comments Download
M headless/public/headless_shell.h View 1 chunk +2 lines, -16 lines 0 comments Download
M headless/public/util/deterministic_http_protocol_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M headless/public/util/generic_url_request_job.h View 1 4 chunks +3 lines, -4 lines 0 comments Download
M headless/public/util/testing/generic_url_request_mocks.cc View 1 chunk +0 lines, -1 line 0 comments Download
M headless/test/headless_browser_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 36 (21 generated)
dvallet
Created Revert of Add --headless flag to Windows
3 years, 8 months ago (2017-04-24 23:37:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837093003/1
3 years, 8 months ago (2017-04-24 23:37:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 8 months ago (2017-04-24 23:37:34 UTC) #5
hans
lgtm
3 years, 8 months ago (2017-04-25 02:03:36 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837093003/300001
3 years, 8 months ago (2017-04-25 02:05:22 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:300001) as https://chromium.googlesource.com/chromium/src/+/4c5022c615824a6e2ad67db5eec5a093e3111e2d
3 years, 8 months ago (2017-04-25 02:20:05 UTC) #22
findit-for-me
Findit(https://goo.gl/kROfz5) identified this CL at revision 466871 as the culprit for failures in the build ...
3 years, 8 months ago (2017-04-25 03:14:11 UTC) #23
dvallet
A revert of this CL (patchset #3 id:300001) has been created in https://codereview.chromium.org/2836843005/ by dvallet@chromium.org. ...
3 years, 8 months ago (2017-04-25 04:02:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837093003/320001
3 years, 8 months ago (2017-04-25 04:29:45 UTC) #28
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/419421)
3 years, 8 months ago (2017-04-25 04:36:55 UTC) #30
dvallet
On 2017/04/25 04:29:45, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 8 months ago (2017-04-25 04:37:14 UTC) #31
dvallet
A revert of this CL (patchset #3 id:300001) has been created in https://codereview.chromium.org/2840693003/ by dvallet@chromium.org. ...
3 years, 8 months ago (2017-04-25 04:48:35 UTC) #33
dvallet
On 2017/04/25 04:48:35, dvallet wrote: > A revert of this CL (patchset #3 id:300001) has ...
3 years, 8 months ago (2017-04-25 06:50:58 UTC) #34
dvallet
On 2017/04/25 04:48:35, dvallet wrote: > A revert of this CL (patchset #3 id:300001) has ...
3 years, 8 months ago (2017-04-25 06:51:03 UTC) #35
dvallet
3 years, 8 months ago (2017-04-25 06:51:06 UTC) #36
Message was sent while issue was closed.
On 2017/04/25 04:48:35, dvallet wrote:
> A revert of this CL (patchset #3 id:300001) has been created in
> https://codereview.chromium.org/2840693003/ by mailto:dvallet@chromium.org.
> 
> The reason for reverting is: Revert is breaking Mac build.

This CL should fix the issue with no need to revert:
https://codereview.chromium.org/2840713003/

Powered by Google App Engine
This is Rietveld 408576698