Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 2837043002: Notify Skia of texture binding changes in SkCanvasVideoRenderer. (Closed)

Created:
3 years, 8 months ago by bsalomon
Modified:
3 years, 8 months ago
Reviewers:
jrummell
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, brianosman_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Notify Skia of texture binding changes in SkCanvasVideoRenderer. This fixes an issue where WebGL conformance tests failed after a Skia roll (http://crbug.com/705156). The problem is that Skia is sharing a GL context with SkCanvasVideoRenderer and SkCanvasVideoRenderer changes which textures are bound. Skia needs to be notified that the GL context state has changed. BUG=skia:6433 Review-Url: https://codereview.chromium.org/2837043002 Cr-Commit-Position: refs/heads/master@{#467086} Committed: https://chromium.googlesource.com/chromium/src/+/06770acc2b3a57d52f6b8ea598494f089d20ed81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/renderers/skcanvas_video_renderer.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
bsalomon
PTAL
3 years, 8 months ago (2017-04-25 13:35:24 UTC) #7
jrummell
lgtm
3 years, 8 months ago (2017-04-25 17:44:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837043002/1
3 years, 8 months ago (2017-04-25 17:49:02 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 20:09:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/06770acc2b3a57d52f6b8ea59849...

Powered by Google App Engine
This is Rietveld 408576698