Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2837033002: Revert 2841523002 (Closed)

Created:
3 years, 7 months ago by bsheedy
Modified:
3 years, 7 months ago
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert 2841523002 Reverts 2841523002 which disabled 7 WebVR tests that were failing due to 2831733003. BUG=713781 Review-Url: https://codereview.chromium.org/2837033002 Cr-Commit-Position: refs/heads/master@{#467068} Committed: https://chromium.googlesource.com/chromium/src/+/f8fdd880c98f3a9edc67a301cd6b92e1ff87afa6

Patch Set 1 #

Patch Set 2 : Rebase to get fix #

Patch Set 3 : Make VrShell fix work with re-enabled tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java View 1 2 1 chunk +1 line, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrUtils.java View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/WebVrTest.java View 1 2 8 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
bsheedy
PTAL
3 years, 7 months ago (2017-04-24 17:16:39 UTC) #2
bsheedy
Looks like there's actually two issues, one of which wasn't fixed by the revert of ...
3 years, 7 months ago (2017-04-24 18:31:28 UTC) #7
David Trainor- moved to gerrit
lgtm
3 years, 7 months ago (2017-04-25 03:25:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837033002/20001
3 years, 7 months ago (2017-04-25 17:56:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837033002/40001
3 years, 7 months ago (2017-04-25 18:50:57 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 19:13:10 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f8fdd880c98f3a9edc67a301cd6b...

Powered by Google App Engine
This is Rietveld 408576698