Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Issue 2837023004: Moved code dealing with accessibility tree from switch_access.js to new file, automation_manager.js (Closed)

Created:
3 years, 8 months ago by elichtenberg
Modified:
3 years, 7 months ago
Reviewers:
dmazzoni, David Tseng
CC:
chromium-reviews, alemate+watch_chromium.org, jlklein+watch-closure_chromium.org, oshima+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved code dealing with accessibility tree from switch_access.js to new file, automation_manager.js BUG=593885 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2837023004 Cr-Commit-Position: refs/heads/master@{#468461} Committed: https://chromium.googlesource.com/chromium/src/+/54d7621cf287e13cc182435ae18ae69742839473

Patch Set 1 #

Patch Set 2 : Small documentation change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -196 lines) Patch
M chrome/browser/resources/chromeos/switch_access/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/switch_access/automation_manager.js View 9 chunks +16 lines, -96 lines 0 comments Download
M chrome/browser/resources/chromeos/switch_access/compiled_resources2.gyp View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/switch_access/manifest.json.jinja2 View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/switch_access/switch_access.js View 1 3 chunks +19 lines, -99 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
elichtenberg
3 years, 8 months ago (2017-04-25 20:56:25 UTC) #5
dmazzoni
lgtm
3 years, 7 months ago (2017-05-01 20:58:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837023004/20001
3 years, 7 months ago (2017-05-01 21:10:39 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 22:37:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/54d7621cf287e13cc182435ae18a...

Powered by Google App Engine
This is Rietveld 408576698