Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 2836933003: DXVA; choose pbuffers with the right number of bits when possible (Closed)

Created:
3 years, 8 months ago by hubbe
Modified:
3 years, 7 months ago
Reviewers:
Geoff Lang, jbauman
CC:
chromium-reviews, posciak+watch_chromium.org, piman+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DXVA; choose pbuffers with the right number of bits when possible This should make it possible to check in RGB10A2 in Angle without breaking video playback performance. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2836933003 Cr-Commit-Position: refs/heads/master@{#467099} Committed: https://chromium.googlesource.com/chromium/src/+/c1243d0272853745e6f1386040578c36102fb6a2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -10 lines) Patch
M media/gpu/dxva_video_decode_accelerator_win.cc View 1 chunk +27 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
hubbe
3 years, 8 months ago (2017-04-24 21:56:19 UTC) #5
Geoff Lang
lgtm (non owner)
3 years, 7 months ago (2017-04-25 13:52:43 UTC) #8
jbauman
lgtm. You also need to fix ChildWindowSurfaceWin::GetConfig (though it's possible that won't hit this config).
3 years, 7 months ago (2017-04-25 20:22:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836933003/1
3 years, 7 months ago (2017-04-25 20:27:13 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 20:35:42 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c1243d0272853745e6f138604057...

Powered by Google App Engine
This is Rietveld 408576698