Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2836913003: Remove unneeded enum forward declaration (Closed)

Created:
3 years, 8 months ago by brucedawson
Modified:
3 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded enum forward declaration Forward declaring of enums without specifying a type is illegal. This forward declaration only worked because it wasn't needed. It was found by VC++'s overzealous C4471 warning. R=raymes Review-Url: https://codereview.chromium.org/2836913003 Cr-Commit-Position: refs/heads/master@{#467182} Committed: https://chromium.googlesource.com/chromium/src/+/0ce0ee1aa6d9d2db1a7cdc7f000cfe451378d6f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M ppapi/proxy/tcp_socket_resource.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
brucedawson
One more tiny change to fix our unneeded enums forward declarations. PTAL.
3 years, 8 months ago (2017-04-24 23:09:02 UTC) #7
raymes
lgtm
3 years, 7 months ago (2017-04-25 22:11:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836913003/1
3 years, 7 months ago (2017-04-25 23:10:11 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-26 00:45:04 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0ce0ee1aa6d9d2db1a7cdc7f000c...

Powered by Google App Engine
This is Rietveld 408576698