Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2836893002: [turbofan] Merge PropertyAccessInfo for compatible field loads. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Merge PropertyAccessInfo for compatible field loads. For polymorphic loads that refer to the same underlying field, but differ in either representation or field maps, try harder to merge them into a simple field load by going to Tagged representation or throwing away the field maps (this is essentially what Crankshaft is doing). R=jarin@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2836893002 Cr-Commit-Position: refs/heads/master@{#44831} Committed: https://chromium.googlesource.com/v8/v8/+/1c1a884d4f6dbe3c68796f3fd5b46b99aac2b335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -9 lines) Patch
M src/compiler/access-info.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 3 chunks +37 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
3 years, 8 months ago (2017-04-24 09:03:34 UTC) #1
Jarin
lgtm
3 years, 8 months ago (2017-04-25 08:20:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836893002/1
3 years, 8 months ago (2017-04-25 08:21:15 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:22:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1c1a884d4f6dbe3c68796f3fd5b46b99aac...

Powered by Google App Engine
This is Rietveld 408576698