Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2836853003: scheduler: Use PLATFORM_EXPORT instead of BLINK_PLATFORM_EXPORT (Closed)

Created:
3 years, 8 months ago by Sami
Modified:
3 years, 8 months ago
Reviewers:
altimin
CC:
chromium-reviews, blink-reviews, kinuko+watch, scheduler-bugs_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Use PLATFORM_EXPORT instead of BLINK_PLATFORM_EXPORT Since the scheduler classes don't need to be exposed to content, the PLATFORM_EXPORT macro is more appropriate for controlling their visibility. BUG=696001, 701223 Review-Url: https://codereview.chromium.org/2836853003 Cr-Commit-Position: refs/heads/master@{#467391} Committed: https://chromium.googlesource.com/chromium/src/+/5ea78625e749782bff7e8009a66f90afa850ffbb

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -88 lines) Patch
M third_party/WebKit/Source/platform/scheduler/base/lazy_now.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/queueing_time_estimator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/real_time_domain.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_manager_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_queue_selector.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/task_time_observer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/virtual_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/base/work_queue_sets.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/idle_canceled_delayed_task_sweeper.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/idle_helper.h View 2 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/scheduler_tqm_delegate_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/web_task_runner_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/webthread_impl_for_worker_scheduler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/worker_global_scope_scheduler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/child/worker_scheduler_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/auto_advancing_virtual_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/budget_pool.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/deadline_task_runner.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/idle_time_estimator.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/render_widget_signals.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_cost_estimator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h View 1 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/user_model.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/renderer/webthread_impl_for_renderer_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/scheduler/utility/webthread_impl_for_utility_thread.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
Sami
3 years, 8 months ago (2017-04-24 17:32:09 UTC) #3
altimin
great, lgtm!
3 years, 8 months ago (2017-04-24 17:34:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836853003/1
3 years, 8 months ago (2017-04-25 13:42:46 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/164353) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 8 months ago (2017-04-25 13:46:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836853003/20001
3 years, 8 months ago (2017-04-26 18:34:16 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 18:44:46 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5ea78625e749782bff7e8009a66f...

Powered by Google App Engine
This is Rietveld 408576698