Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2836853002: [turbofan] Fix FinishRegion handling in NodeProperties::InferReceiverMaps. (Closed)

Created:
3 years, 8 months ago by Benedikt Meurer
Modified:
3 years, 8 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix FinishRegion handling in NodeProperties::InferReceiverMaps. When looking for receiver maps, we need to account for the renaming performed by FinishRegion, and look for the original receiver instead from that point on. Drive-by-fix: Abort effect chain walk as soon as the definition of the receiver is seen on the effect chain. BUG=v8:5267 Review-Url: https://codereview.chromium.org/2836853002 Cr-Commit-Position: refs/heads/master@{#44833} Committed: https://chromium.googlesource.com/v8/v8/+/904e5df567844939a065f558ea338cbdc05eb2cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/compiler/node-properties.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
Hey Jaro, Here's a fix for the receiver maps inferrer. Please take a look. Thanks, ...
3 years, 8 months ago (2017-04-24 07:43:34 UTC) #6
Jarin
lgtm
3 years, 8 months ago (2017-04-25 08:21:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836853002/1
3 years, 8 months ago (2017-04-25 08:30:04 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 08:54:28 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/904e5df567844939a065f558ea338cbdc05...

Powered by Google App Engine
This is Rietveld 408576698