Change LocaleManager to accommodate more dialog flows

Change LocaleManager to accommodate more dialog flows

Adds two more dialogs, one for new and one for existing devices
and changes the flow to return a SHOW value declaring which dialog
to show. Also adds features for these two new dialogs to variations.

BUG=712833, 712836
Review-Url: https://codereview.chromium.org/2836833002
Cr-Commit-Position: refs/heads/master@{#466823}
Committed: https://chromium.googlesource.com/chromium/src/+/dcb37de1f6962d7e2fef16098b271ce7f49dd960

[Yusuf, 2017-04-24 04:36:08]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org, tedchoc@chromium.org

[gone, 2017-04-24 19:59:14]

+1

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
(right):

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:33:
public static final int SEARCH_ENGINE_PROMO_DONT_SHOW = -1;
@IntDef

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:167:
* Shows a promotion dialog saying the default search engine will be set to
Sogou. No-op if
Update the comments.

[gone, 2017-04-24 20:30:34]

(lgtm % tedchoc@)

[Ted C, 2017-04-24 21:34:00]

lgtm

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
(right):

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:228:
protected int shouldShowSearchEnginePromo() {
bikesheding!  but I think shouldShow implies a boolean to me.

I wonder if getSearchEnginePromoShowType implies more clearly it can be a
multitude of glorious options.

[Yusuf, 2017-04-24 21:49:56]

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java
(right):

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:33:
public static final int SEARCH_ENGINE_PROMO_DONT_SHOW = -1;
On 2017/04/24 19:59:13, slow (dfalcantara) wrote:
> @IntDef

Done.

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:167:
* Shows a promotion dialog saying the default search engine will be set to
Sogou. No-op if
On 2017/04/24 19:59:13, slow (dfalcantara) wrote:
> Update the comments.

Done.

https://codereview.chromium.org/2836833002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java:228:
protected int shouldShowSearchEnginePromo() {
On 2017/04/24 21:34:00, Ted C wrote:
> bikesheding!  but I think shouldShow implies a boolean to me.
> 
> I wonder if getSearchEnginePromoShowType implies more clearly it can be a
> multitude of glorious options. 

Done.

[Yusuf, 2017-04-24 22:51:27]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-04-24 22:51:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2836833002/#ps40001
(title: "retention policy")

[commit-bot: I haz the power, 2017-04-24 22:52:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 23:31:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493074287914910,
"parent_rev": "8b2c1f9d654df94508218898117d4cdf20f11159", "commit_rev":
"dcb37de1f6962d7e2fef16098b271ce7f49dd960"}

[commit-bot: I haz the power, 2017-04-24 23:33:29]

Description was changed from

==========
Change LocaleManager to accommodate more dialog flows

Adds two more dialogs, one for new and one for existing devices
and changes the flow to return a SHOW value declaring which dialog
to show. Also adds features for these two new dialogs to variations.

BUG=712833, 712836
==========

to

==========
Change LocaleManager to accommodate more dialog flows

Adds two more dialogs, one for new and one for existing devices
and changes the flow to return a SHOW value declaring which dialog
to show. Also adds features for these two new dialogs to variations.

BUG=712833, 712836

Review-Url: https://codereview.chromium.org/2836833002
Cr-Commit-Position: refs/heads/master@{#466823}
Committed:
https://chromium.googlesource.com/chromium/src/+/dcb37de1f6962d7e2fef16098b27...
==========

[commit-bot: I haz the power, 2017-04-24 23:33:31]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/dcb37de1f6962d7e2fef16098b27...