Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2836823002: Fix DCHECH errors on Windows (Closed)

Created:
3 years, 8 months ago by dvallet
Modified:
3 years, 7 months ago
Reviewers:
jzfeng, Sami
CC:
chromium-reviews, Will Harris
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DCHECH errors on Windows - Disable initLogging in child processes in Windows, since they always fail to initialize. - Add RunChildProcessIfNeeded method to Windows, to make it more consistent with Linux implementation and allowing for proper DCHECK test in HeadlessBrowserMain entry point - Fix issue with headless_shell not containing windows exe manifest BUG=686608

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -11 lines) Patch
M headless/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M headless/app/headless_shell.cc View 1 chunk +1 line, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +11 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (7 generated)
dvallet
PTAL
3 years, 8 months ago (2017-04-24 04:51:05 UTC) #8
jzfeng
lgtm
3 years, 8 months ago (2017-04-24 05:01:51 UTC) #9
Sami
3 years, 8 months ago (2017-04-24 19:00:56 UTC) #10
lgtm

Powered by Google App Engine
This is Rietveld 408576698