Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2836813007: [webnfc] Reject promise if passed timeout value is invalid (Closed)

Created:
2 years, 4 months ago by shalamov
Modified:
2 years, 4 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Reject promise if passed timeout value is invalid According to latest changes in specification [1,2], when invalid NFCPushOptions.timeout is provided to nfc.push function, promise must be rejected with TypeError. [1] https://w3c.github.io/web-nfc/#dom-nfc-push [2] https://github.com/w3c/web-nfc/issues/112 BUG=714035 Review-Url: https://codereview.chromium.org/2836813007 Cr-Commit-Position: refs/heads/master@{#467265} Committed: https://chromium.googlesource.com/chromium/src/+/d5514f4cd0a146298f52a96ac5f75b58f95b2980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/nfc/push.html View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
shalamov
Please take a look.
2 years, 4 months ago (2017-04-25 15:48:51 UTC) #4
Reilly Grant (use Gerrit)
lgtm
2 years, 4 months ago (2017-04-25 19:54:40 UTC) #7
haraken
LGTM
2 years, 4 months ago (2017-04-26 01:31:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836813007/1
2 years, 4 months ago (2017-04-26 08:15:30 UTC) #10
commit-bot: I haz the power
2 years, 4 months ago (2017-04-26 08:20:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d5514f4cd0a146298f52a96ac5f7...

Powered by Google App Engine
This is Rietveld 408576698