Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2836793002: Add P3 and Rec2020 to ImageBitmap colorSpaceConversion modes (Closed)

Created:
3 years, 8 months ago by zakerinasab
Modified:
3 years, 7 months ago
Reviewers:
fserb, Justin Novosad
CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, Rik, Stephen Chennney, blink-reviews, blink-reviews-frames_chromium.org, ajuma+watch_chromium.org, kinuko+watch, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add P3 and Rec2020 to ImageBitmap colorSpaceConversion modes Currently, ImageBitmapOptions accepts 'none', 'default', 'srgb' and 'linear-rgb' color space conversion modes. This CL adds 'p3' and 'rec2020' to the list according to https://github.com/WICG/canvas-color-space/blob/master/CanvasColorSpaceProposal.md. This CL also uses ColorCanvasParams to keep the color space settings. BUG=714266 Review-Url: https://codereview.chromium.org/2836793002 Cr-Commit-Position: refs/heads/master@{#467655} Committed: https://chromium.googlesource.com/chromium/src/+/e8ebeeb0dc1bc8f404e5d4be970fcb6998ca41d8

Patch Set 1 #

Patch Set 2 : Corrections #

Patch Set 3 : Minor corrections #

Patch Set 4 : Fixing unit test fails #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -137 lines) Patch
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 2 3 17 chunks +107 lines, -132 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 2 3 5 chunks +48 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/imagebitmap/ImageBitmapOptions.idl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasColorParams.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/CanvasColorParams.cpp View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (6 generated)
Justin Novosad
lgtm
3 years, 8 months ago (2017-04-26 18:47:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836793002/60001
3 years, 7 months ago (2017-04-27 11:41:44 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 13:21:39 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e8ebeeb0dc1bc8f404e5d4be970f...

Powered by Google App Engine
This is Rietveld 408576698