Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2836763002: M59: WebUI: Fix calculation of md-select text and arrow spacing. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

M59: WebUI: Fix calculation of md-select text and arrow spacing. Previous calculation was not properly taking into account the position of the arrow. New calculation ensures that there is always some white space between the arrow and the text. BUG=693698, 710802 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2825403003 Cr-Commit-Position: refs/heads/master@{#465800} (cherry picked from commit 25e4011a30bc7e0cbb2912ea1fe47defefa606f8) Review-Url: https://codereview.chromium.org/2836763002 . Cr-Commit-Position: refs/branch-heads/3071@{#138} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/6eb1222c5a221fc570b5a2cee9e418c496a3b55a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M ui/webui/resources/html/md_select_css.html View 2 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Lei Zhang
Committed patchset #1 (id:1) manually as 6eb1222c5a221fc570b5a2cee9e418c496a3b55a.
3 years, 8 months ago (2017-04-21 23:57:26 UTC) #2
dpapad
3 years, 8 months ago (2017-04-21 23:58:01 UTC) #4
Message was sent while issue was closed.
LGTM stamp (the diff looks identical to the original CL).

Powered by Google App Engine
This is Rietveld 408576698