Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Issue 2836733003: Fix extra-long USB chooser dialog (Closed)

Created:
3 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
3 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix extra-long USB chooser dialog It appears that setting a minimum size on the DialogViewClient in CreateClientView causes the GridLayout to use that size for all cells. This means that both the DeviceChooserContentView and the button row below it are set to the same height, effectively doubling the size of the window. Removing the call to set_minimum_size seems to restore the window to its proper size. BUG=714147 Review-Url: https://codereview.chromium.org/2836733003 Cr-Commit-Position: refs/heads/master@{#466597} Committed: https://chromium.googlesource.com/chromium/src/+/b06115fcd1a2aee65694061710aa1342528f8afe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Reilly Grant (use Gerrit)
PTAL. I don't understand Views.
3 years, 8 months ago (2017-04-21 23:00:55 UTC) #2
benwells
lgtm
3 years, 8 months ago (2017-04-24 05:41:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836733003/1
3 years, 8 months ago (2017-04-24 07:01:27 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 08:42:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b06115fcd1a2aee65694061710aa...

Powered by Google App Engine
This is Rietveld 408576698