Use RefCountedThreadSafe in GPU IDC

Use RefCountedThreadSafe in GPU IDC

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2836703003
Cr-Commit-Position: refs/heads/master@{#467793}
Committed: https://chromium.googlesource.com/chromium/src/+/90567cc4853a3df94213a410c76ee9f981b75ecc

[ericrk, 2017-04-21 20:30:23]

Description was changed from

==========
Use RefCountedThreadSafe in GPU IDC

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
==========

to

==========
Use RefCountedThreadSafe in GPU IDC

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ericrk, 2017-04-21 20:35:43]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 20:36:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 21:56:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 21:56:52]

Dry run: This issue passed the CQ dry run.

[vmpstr, 2017-04-26 22:28:03]

lgtm

[ericrk, 2017-04-26 22:28:07]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-04-26 22:29:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 00:19:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:19:30]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-04-27 19:53:39]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-04-27 19:54:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 21:25:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493322819962520, "parent_rev":
"7a2e1cc92b74ecd7dff00e5cc91e7f21f97dc7cd", "commit_rev":
"90567cc4853a3df94213a410c76ee9f981b75ecc"}

[commit-bot: I haz the power, 2017-04-27 21:26:08]

Description was changed from

==========
Use RefCountedThreadSafe in GPU IDC

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Use RefCountedThreadSafe in GPU IDC

Currently GPU Image Decode Controller uses a base::RefCounted object.
This object isn't thread safe, which is fine, as GPUIDC holds a lock
during access. However, the RefCounted object can't detect that the
usage is safe and raises a DCHECK.

This change just makes the object a RefCountedThreadSafe. Ref/Unref
should be rare enough that this won't have a big impact. And is easier
than working around the DCHECK in another way.

R=vmpstr@chromium.org
BUG=714245
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2836703003
Cr-Commit-Position: refs/heads/master@{#467793}
Committed:
https://chromium.googlesource.com/chromium/src/+/90567cc4853a3df94213a410c76e...
==========

[commit-bot: I haz the power, 2017-04-27 21:26:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/90567cc4853a3df94213a410c76e...