Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 2836603002: cros: Reboot the system after encryption migration finishes. (Closed)

Created:
3 years, 8 months ago by fukino
Modified:
3 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, dspaid
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Reboot the system after encryption migration finishes. It should be safer to restart the system to make sure that cryptohome's states (mount points, etc...) are re-initialized after the migration process. BUG=714075 TEST=manually tested the reboot senario after migration Review-Url: https://codereview.chromium.org/2836603002 Cr-Commit-Position: refs/heads/master@{#466355} Committed: https://chromium.googlesource.com/chromium/src/+/75aa8c950b7aa4b9e0fe8404335294f3576431b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
fukino
PTAL. Thanks!
3 years, 8 months ago (2017-04-21 10:10:58 UTC) #2
xiyuan
lgtm
3 years, 8 months ago (2017-04-21 15:13:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836603002/1
3 years, 8 months ago (2017-04-21 15:48:27 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 16:20:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/75aa8c950b7aa4b9e0fe84043352...

Powered by Google App Engine
This is Rietveld 408576698