Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2836593002: Check the existence of provider_host in ServiceWorkerURLTrackingRequestHandler::MaybeCreateJob() (Closed)

Created:
3 years, 8 months ago by horo
Modified:
3 years, 8 months ago
Reviewers:
nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, tzik, blink-worker-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Check the existence of provider_host in ServiceWorkerURLTrackingRequestHandler::MaybeCreateJob() The provider host may have been deleted when the request is resumed. BUG=714065 Review-Url: https://codereview.chromium.org/2836593002 Cr-Commit-Position: refs/heads/master@{#466884} Committed: https://chromium.googlesource.com/chromium/src/+/63beb1489dd2cacf6675b2a24d9b254a669fdc70

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/service_worker/service_worker_provider_host.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
horo
nhiroki@ Please review this.
3 years, 8 months ago (2017-04-21 09:36:25 UTC) #4
nhiroki
Change itself looks good. Can you explain an example case where this may happen and ...
3 years, 8 months ago (2017-04-25 02:00:46 UTC) #7
nhiroki
lgtm
3 years, 8 months ago (2017-04-25 02:01:46 UTC) #8
horo
On 2017/04/25 02:00:46, nhiroki wrote: > Change itself looks good. > > Can you explain ...
3 years, 8 months ago (2017-04-25 02:07:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836593002/1
3 years, 8 months ago (2017-04-25 02:08:24 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 05:24:04 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/63beb1489dd2cacf6675b2a24d9b...

Powered by Google App Engine
This is Rietveld 408576698