Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2836573003: [Sync] Add task ids to proto visitor for tab sync (Closed)

Created:
3 years, 8 months ago by Nicolas Zea
Modified:
3 years, 8 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Add task ids to proto visitor for tab sync Proto visitors allow seeing the sync data in chrome://sync-internals BUG=707978 Review-Url: https://codereview.chromium.org/2836573003 Cr-Commit-Position: refs/heads/master@{#466676} Committed: https://chromium.googlesource.com/chromium/src/+/4c16aaa21c6f8a4cc6b392a9474fda426f9f36a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/sync/protocol/proto_visitors.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Nicolas Zea
PTAL (forgot to add this when the proto was updated)
3 years, 8 months ago (2017-04-21 22:35:20 UTC) #2
skym
lgtm
3 years, 8 months ago (2017-04-21 22:57:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836573003/1
3 years, 8 months ago (2017-04-24 16:57:20 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 17:46:19 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4c16aaa21c6f8a4cc6b392a9474f...

Powered by Google App Engine
This is Rietveld 408576698