Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2836543002: Revert of [CrOS Tether] Add the notion of a tether DeviceState. (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, stevenjb+watch_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, oshima+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [CrOS Tether] Add the notion of a tether DeviceState. (patchset #12 id:220001 of https://codereview.chromium.org/2819993002/ ) Reason for revert: NetworkStateHandlerTest.TetherTechnologyState started failing on Linux ChromiumOS Tests (dbg) https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25133 https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/25132 Original issue's description: > [CrOS Tether] Add the notion of a tether DeviceState. > > This CL: > (1) Adds a tether DeviceState to NetworkStateHandler during initialization. > (2) Adds SetTetherTechnologyState() and SetTetherScanState() functions which can be called from the tether component. > (3) Updates the SetTechnologyEnabled(), SetProhibitedTechnologies(), and FormattedHardwareAddressForType() functions to deal properly with the tether DeviceState. > (4) Adds a new TetherDeviceStateManager class to the tether component which will handle setting the appropriate technology state. The class is mostly unimplemented for now. > > BUG=672263 > > Review-Url: https://codereview.chromium.org/2819993002 > Cr-Commit-Position: refs/heads/master@{#466185} > Committed: https://chromium.googlesource.com/chromium/src/+/5df3c973662600cb69c4d5e6ac8ae0d1870d10dc TBR=stevenjb@chromium.org,hansberry@chromium.org,khorimoto@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=672263 Review-Url: https://codereview.chromium.org/2836543002 Cr-Commit-Position: refs/heads/master@{#466210} Committed: https://chromium.googlesource.com/chromium/src/+/190b7dd412a2f782a2b7c0b671778e1c00a48563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -400 lines) Patch
M chromeos/components/tether/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/components/tether/active_host_network_state_updater_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/components/tether/host_scanner_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/components/tether/initializer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chromeos/components/tether/initializer.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/components/tether/tether_connector_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D chromeos/components/tether/tether_device_state_manager.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chromeos/components/tether/tether_device_state_manager.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M chromeos/network/device_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/managed_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/network/network_connect_unittest.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chromeos/network/network_connection_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/network/network_state_handler.h View 5 chunks +2 lines, -25 lines 0 comments Download
M chromeos/network/network_state_handler.cc View 16 chunks +11 lines, -146 lines 0 comments Download
M chromeos/network/network_state_handler_unittest.cc View 14 chunks +6 lines, -106 lines 0 comments Download
M chromeos/network/tether_constants.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chromeos/network/tether_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
keishi
Created Revert of [CrOS Tether] Add the notion of a tether DeviceState.
3 years, 8 months ago (2017-04-21 01:19:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836543002/1
3 years, 8 months ago (2017-04-21 01:20:08 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 01:21:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/190b7dd412a2f782a2b7c0b67177...

Powered by Google App Engine
This is Rietveld 408576698