Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Issue 2836503002: Handle empty response to FTP QUIT message. (Closed)

Created:
3 years, 8 months ago by Lei Zhang
Modified:
3 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org, Paweł Hajdan Jr.
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle empty response to FTP QUIT message. Just pretend it is ok, rather than returning an error. BUG=633841 Review-Url: https://codereview.chromium.org/2836503002 Cr-Commit-Position: refs/heads/master@{#466388} Committed: https://chromium.googlesource.com/chromium/src/+/e1eca6ba538bdcbd4fe8d78c9bb208ec1b818702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -14 lines) Patch
M net/ftp/ftp_network_transaction.h View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_network_transaction.cc View 8 chunks +21 lines, -13 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Lei Zhang
3 years, 8 months ago (2017-04-21 03:59:16 UTC) #6
Paweł Hajdan Jr.
LGTM
3 years, 8 months ago (2017-04-21 08:19:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836503002/1
3 years, 8 months ago (2017-04-21 18:01:01 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 18:06:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e1eca6ba538bdcbd4fe8d78c9bb2...

Powered by Google App Engine
This is Rietveld 408576698