Draw multi window resize controls programmatically

Draw multi window resize controls programmatically
instead of using assets.

BUG=708218
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2836493002
Cr-Commit-Position: refs/heads/master@{#467743}
Committed: https://chromium.googlesource.com/chromium/src/+/859a37371104d1cbea1afe33cdc59a31d335ce02

[Evan Stade, 2017-04-21 00:28:44]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 00:28:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 00:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 00:31:12]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Evan Stade, 2017-04-21 18:20:00]

estade@chromium.org changed reviewers:
+ varkha@chromium.org

[Evan Stade, 2017-04-25 01:35:41]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 01:36:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 02:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-25 02:05:30]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2017-04-27 02:27:00]

ping Valery

[varkha, 2017-04-27 03:04:29]

lgtm with a couple nits / suggestions.

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:77:
canvas->DrawRoundRect(gfx::RectF(GetLocalBounds()), 2, flags);
s/2/kButtonCornerRadius ?

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:80: SkRect arrow =
SkRect::MakeXYWH(4, 28, 4, 8);
How about arrow_rect?

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:80: SkRect arrow =
SkRect::MakeXYWH(4, 28, 4, 8);
I can see that XYWH makes it less ambiguous but I would still prefer named
constants here.

[Evan Stade, 2017-04-27 17:36:30]

note: I changed the code for the right arrow to be niftier and less
verbose/repetitive/error prone/

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
File ash/wm/workspace/multi_window_resize_controller.cc (right):

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:77:
canvas->DrawRoundRect(gfx::RectF(GetLocalBounds()), 2, flags);
On 2017/04/27 03:04:29, varkha wrote:
> s/2/kButtonCornerRadius ?

I prefer not to used named constants for values that are only used once. They
add verbosity and not a whole lot of clarity and create the false implication
that it is used somewhere else as well.

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:80: SkRect arrow =
SkRect::MakeXYWH(4, 28, 4, 8);
On 2017/04/27 03:04:29, varkha wrote:
> I can see that XYWH makes it less ambiguous but I would still prefer named
> constants here.

Indeed, the XYHW serve as names. The only difference I see is that these are all
on the same line and the code is documenting itself (variable names can be self
documenting but they aren't actually enforced by anything, whereas there's
greater assuredness a library function called XYWH really means XYWH).

https://codereview.chromium.org/2836493002/diff/1/ash/wm/workspace/multi_wind...
ash/wm/workspace/multi_window_resize_controller.cc:80: SkRect arrow =
SkRect::MakeXYWH(4, 28, 4, 8);
On 2017/04/27 03:04:29, varkha wrote:
> How about arrow_rect?

changed to kArrowRect

[Evan Stade, 2017-04-27 17:36:47]

Description was changed from

==========
Draw multi window resize controls programmatically
instead of using assets.

BUG=708218
==========

to

==========
Draw multi window resize controls programmatically
instead of using assets.

BUG=708218
TBR=oshima@chromium.org
==========

[Evan Stade, 2017-04-27 17:36:47]

estade@chromium.org changed reviewers:
+ oshima@chromium.org

[Evan Stade, 2017-04-27 17:36:56]

TBR oshima for resource deletions.

[Evan Stade, 2017-04-27 17:37:07]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2017-04-27 17:37:07]

The patchset sent to the CQ was uploaded after l-g-t-m from varkha@chromium.org
Link to the patchset: https://codereview.chromium.org/2836493002/#ps20001
(title: "slicker way of making right arrow")

[commit-bot: I haz the power, 2017-04-27 17:37:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oshima, 2017-04-27 17:48:45]

lgtm

[commit-bot: I haz the power, 2017-04-27 19:09:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493314627464310,
"parent_rev": "62ffefbb0a2dcd9d0ff0a1a12288577c766af408", "commit_rev":
"859a37371104d1cbea1afe33cdc59a31d335ce02"}

[commit-bot: I haz the power, 2017-04-27 19:09:49]

Description was changed from

==========
Draw multi window resize controls programmatically
instead of using assets.

BUG=708218
TBR=oshima@chromium.org
==========

to

==========
Draw multi window resize controls programmatically
instead of using assets.

BUG=708218
TBR=oshima@chromium.org

Review-Url: https://codereview.chromium.org/2836493002
Cr-Commit-Position: refs/heads/master@{#467743}
Committed:
https://chromium.googlesource.com/chromium/src/+/859a37371104d1cbea1afe33cdc5...
==========

[commit-bot: I haz the power, 2017-04-27 19:09:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/859a37371104d1cbea1afe33cdc5...