Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(730)

Issue 2836453002: Standardizing on the name "tail suggestions" (in comments) (Closed)

Created:
3 years, 8 months ago by Kevin Bailey
Modified:
3 years, 8 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, tfarina, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Standardizing on the name "tail suggestions" (in comments) The name of the feature changed over time. Changing all comments from "infinite" and "postfix" to "tail" suggestions. BUG=713837 Review-Url: https://codereview.chromium.org/2836453002 Cr-Commit-Position: refs/heads/master@{#466257} Committed: https://chromium.googlesource.com/chromium/src/+/51ccd0e9ec5db8cc0b554d66d03f937648ae540a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/omnibox/browser/search_suggestion_parser.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (9 generated)
Kevin Bailey
groby@, could you bless the cocoa files? thx
3 years, 8 months ago (2017-04-20 22:01:31 UTC) #3
groby-ooo-7-16
Since Peter is OOO, +msw msw: Would you mind rubberstamping Views? It's a comments-only change. ...
3 years, 8 months ago (2017-04-20 23:02:22 UTC) #5
msw
c/b/ui/views rubber stamp lgtm
3 years, 8 months ago (2017-04-20 23:04:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836453002/1
3 years, 8 months ago (2017-04-20 23:55:45 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/417079)
3 years, 8 months ago (2017-04-21 00:05:09 UTC) #10
Kevin Bailey
Hi Mark, Could you bless search_suggestion_parser.h? (odd that it didn't notice until that one build)
3 years, 8 months ago (2017-04-21 01:44:42 UTC) #12
Mark P
components/omnibox/browser/search_suggestion_parser.h lgtm
3 years, 8 months ago (2017-04-21 04:05:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836453002/1
3 years, 8 months ago (2017-04-21 04:11:31 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-21 04:17:26 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/51ccd0e9ec5db8cc0b554d66d03f...

Powered by Google App Engine
This is Rietveld 408576698