Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2836423003: Added owners for enterprise code. (Closed)

Created:
2 years, 1 month ago by The one and only Dr. Crash
Modified:
2 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, dkrahn+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Added owners for enterprise code. BUG=none Review-Url: https://codereview.chromium.org/2836423003 Cr-Commit-Position: refs/heads/master@{#467309} Committed: https://chromium.googlesource.com/chromium/src/+/79a8c1f3a373b60846fd2a163966b7f8e30991a6

Patch Set 1 #

Total comments: 1

Patch Set 2 : Reordered owner. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/extensions/api/enterprise_platform_keys/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/enterprise_platform_keys_private/OWNERS View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
The one and only Dr. Crash
We'd like the owners in enterprise code to reflect people working on the code. This ...
2 years, 1 month ago (2017-04-26 08:52:47 UTC) #1
The one and only Dr. Crash
2 years, 1 month ago (2017-04-26 10:33:20 UTC) #3
The one and only Dr. Crash
2 years, 1 month ago (2017-04-26 10:35:37 UTC) #5
Mattias Nissler (ping if slow)
LGTM provided emaxx@ is OK with this too (he's the most competent owner at this ...
2 years, 1 month ago (2017-04-26 11:26:18 UTC) #7
emaxx
lgtm, I'm fine with taking this on
2 years, 1 month ago (2017-04-26 11:47:38 UTC) #8
The one and only Dr. Crash
Mattias, I'll reorder the names in the first OWNERS file to put us first but ...
2 years, 1 month ago (2017-04-26 12:21:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836423003/20001
2 years, 1 month ago (2017-04-26 12:41:10 UTC) #12
commit-bot: I haz the power
2 years, 1 month ago (2017-04-26 12:57:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/79a8c1f3a373b60846fd2a163966...

Powered by Google App Engine
This is Rietveld 408576698