Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Issue 2836383003: vpython: don't mess with logging in -dev mode. (Closed)

Created:
3 years, 8 months ago by dnj
Modified:
3 years, 8 months ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M vpython/application/application.go View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj
3 years, 8 months ago (2017-04-26 18:40:34 UTC) #1
iannucci
lgtm
3 years, 8 months ago (2017-04-26 18:48:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836383003/1
3 years, 8 months ago (2017-04-26 18:56:45 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 19:04:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/4ed17413723d16c2e4858a878eaea1c4add5c0bf

Powered by Google App Engine
This is Rietveld 408576698