Reland of Reimplement AccountManagerHelper singleton instance creation

Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258, 710901
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2836373003
Cr-Commit-Position: refs/heads/master@{#467619}
Committed: https://chromium.googlesource.com/chromium/src/+/c613e1f102863081348db126d8db74fc11e389fb

[bsazonov, 2017-04-26 09:17:15]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 09:17:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bsazonov, 2017-04-26 09:22:51]

Description was changed from

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258
==========

to

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258
TBR=rogerta@chromium.org
==========

[bsazonov, 2017-04-26 09:38:34]

Description was changed from

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258
TBR=rogerta@chromium.org
==========

to

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258,710901
TBR=rogerta@chromium.org
==========

[bsazonov, 2017-04-26 09:39:45]

bsazonov@chromium.org changed reviewers:
+ nyquist@chromium.org, rogerta@chromium.org

[bsazonov, 2017-04-26 09:39:46]

Tommy, please take a look.
First patch is exact copy of http://crrev.com/2747293005 that was reverted
because of failures in ClearBrowsingDataPreferencesTest (see
http://crbug.com/710901).
I've fixed ClearBrowsingDataPreferencesTest and tested it on Android M.

[commit-bot: I haz the power, 2017-04-26 10:01:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 10:01:37]

Dry run: This issue passed the CQ dry run.

[Roger Tawa OOO till Jul 10th, 2017-04-26 17:15:17]

lgtm

[nyquist, 2017-04-27 04:40:19]

thanks a ton for uploading patch set 1 as the original patch!
lgtm

[bsazonov, 2017-04-27 07:36:00]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-04-27 07:36:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 07:42:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493278560405330,
"parent_rev": "68db6d36ffd81d907994065b71905d44875b3cc9", "commit_rev":
"c613e1f102863081348db126d8db74fc11e389fb"}

[commit-bot: I haz the power, 2017-04-27 07:42:51]

Description was changed from

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258,710901
TBR=rogerta@chromium.org
==========

to

==========
Reland of Reimplement AccountManagerHelper singleton instance creation

Original CL: http://crrev.com/2747293005

Current implementation of AccountManagerHelper can instantiate wrong delegate
type if get() is called in too early. This CL fixes it. AtomicReference is used
to avoid relying on external synchronization, because get() can be called
from different threads. This CL also adds
AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure
there's no interference between tests.

BUG=698258,710901
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2836373003
Cr-Commit-Position: refs/heads/master@{#467619}
Committed:
https://chromium.googlesource.com/chromium/src/+/c613e1f102863081348db126d8db...
==========

[commit-bot: I haz the power, 2017-04-27 07:42:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c613e1f102863081348db126d8db...