[Offline pages] Update of OfflinePageUtils for better testability

[Offline pages] Update of OfflinePageUtils for better testability

This patch introduces Internal interface that is mockable and simplifies
testing classes dependent on OfflinePageUtils.

BUG=711771
R=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2836333004
Cr-Commit-Position: refs/heads/master@{#470393}
Committed: https://chromium.googlesource.com/chromium/src/+/28574ad090e3bdeb2a57b03f1da19aff92d65d7c

[fgorski, 2017-04-26 14:29:20]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 14:29:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fgorski, 2017-04-26 14:29:41]

PTAL

[commit-bot: I haz the power, 2017-04-26 14:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 14:32:56]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[fgorski, 2017-04-26 16:53:33]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 16:54:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 18:13:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 18:13:31]

Dry run: This issue passed the CQ dry run.

[dewittj, 2017-04-27 17:29:14]

lgtm!

https://codereview.chromium.org/2836333004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
(right):

https://codereview.chromium.org/2836333004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java:95:
*/
@visiblefortest

[dewittj, 2017-04-28 20:22:53]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:23:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:28:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:28:43]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fgorski, 2017-05-08 21:41:15]

The CQ bit was checked by fgorski@chromium.org to run a CQ dry run

[fgorski, 2017-05-08 21:41:24]

https://codereview.chromium.org/2836333004/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
(right):

https://codereview.chromium.org/2836333004/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java:95:
*/
On 2017/04/27 17:29:14, dewittj wrote:
> @visiblefortest

Done.

[commit-bot: I haz the power, 2017-05-08 21:42:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 22:47:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:47:10]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[fgorski, 2017-05-09 15:57:33]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2017-05-09 15:57:34]

The patchset sent to the CQ was uploaded after l-g-t-m from dewittj@chromium.org
Link to the patchset: https://codereview.chromium.org/2836333004/#ps40001
(title: "Rebasing and addressing feedback")

[commit-bot: I haz the power, 2017-05-09 15:58:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 18:49:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494345453843880,
"parent_rev": "e4fae85260876af2c08495ccf33b6c3051db1730", "commit_rev":
"28574ad090e3bdeb2a57b03f1da19aff92d65d7c"}

[commit-bot: I haz the power, 2017-05-09 18:50:05]

Description was changed from

==========
[Offline pages] Update of OfflinePageUtils for better testability

This patch introduces Internal interface that is mockable and simplifies
testing classes dependent on OfflinePageUtils.

BUG=711771
R=dewittj@chromium.org
==========

to

==========
[Offline pages] Update of OfflinePageUtils for better testability

This patch introduces Internal interface that is mockable and simplifies
testing classes dependent on OfflinePageUtils.

BUG=711771
R=dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2836333004
Cr-Commit-Position: refs/heads/master@{#470393}
Committed:
https://chromium.googlesource.com/chromium/src/+/28574ad090e3bdeb2a57b03f1da1...
==========

[commit-bot: I haz the power, 2017-05-09 18:50:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/28574ad090e3bdeb2a57b03f1da1...