Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2836293006: Remove TaskScheduler::CreateAndSetSimpleTaskScheduler(). (Closed)

Created:
3 years, 8 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
gab, joedow
CC:
chromium-reviews, ozone-reviews_chromium.org, cbentzel+watch_chromium.org, kalyank, ios-reviews_chromium.org, vmpstr+watch_chromium.org, robliao+watch_chromium.org, chromoting-reviews_chromium.org, jam, net-reviews_chromium.org, gab+watch_chromium.org, darin-cc_chromium.org, fdoray+watch_chromium.org, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove TaskScheduler::CreateAndSetSimpleTaskScheduler(). This method has been replaced by CreateAndStartWithDefaultParams(). TBR=gab@chromium.org BUG=690706 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2836293006 Cr-Commit-Position: refs/heads/master@{#467472} Committed: https://chromium.googlesource.com/chromium/src/+/f264f1a41214087a86a32e5d5497650fcf40cb4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M base/task_scheduler/task_scheduler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M base/task_scheduler/task_scheduler.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/cronet/ios/cronet_environment.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/chromoting_client_runtime.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/it2me/it2me_native_messaging_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/remoting_me2me_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/me2me_native_messaging_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/start_host_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/test/chromoting_test_driver.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/service_manager/embedder/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/demo/ozone_demo.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
fdoray
TBR trivial rename
3 years, 8 months ago (2017-04-26 19:18:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836293006/1
3 years, 8 months ago (2017-04-26 19:19:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/f264f1a41214087a86a32e5d5497650fcf40cb4b
3 years, 8 months ago (2017-04-26 21:55:12 UTC) #9
gab
lgtm
3 years, 7 months ago (2017-04-27 14:34:53 UTC) #10
joedow
3 years, 7 months ago (2017-04-27 15:15:24 UTC) #12
Message was sent while issue was closed.
remoting lgtm

Powered by Google App Engine
This is Rietveld 408576698