Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2836223002: auth: Add a page to setup web client ID for a service. (Closed)

Created:
3 years, 8 months ago by Vadim Sh.
Modified:
3 years, 8 months ago
Reviewers:
nodir
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

auth: Add a page to setup web client ID for a service. Note that LUCI config is undesirable here. A web client ID will be needed for initial setup of Auth Service, but LUCI Config requires a working auth service. If we make Auth Service setup depend on LUCI Config, we'll have a dependency cycle. R=nodir@chromium.org BUG=714821 Review-Url: https://codereview.chromium.org/2836223002 Committed: https://github.com/luci/luci-py/commit/da04014d32632924f7256b27fa0235b727161e23

Patch Set 1 #

Patch Set 2 : nit #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -2 lines) Patch
M appengine/components/components/auth/api.py View 1 4 chunks +41 lines, -1 line 2 comments Download
M appengine/components/components/auth/api_test.py View 4 chunks +12 lines, -0 lines 0 comments Download
M appengine/components/components/auth/ui/templates/bootstrap_done.html View 1 chunk +5 lines, -0 lines 0 comments Download
A appengine/components/components/auth/ui/templates/bootstrap_oauth.html View 1 chunk +29 lines, -0 lines 0 comments Download
M appengine/components/components/auth/ui/ui.py View 3 chunks +38 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Vadim Sh.
PTAL Example page: https://2768-d76c2a4-tainted-vadimsh-dot-chrome-infra-auth-dev.appspot.com/auth/bootstrap/oauth
3 years, 8 months ago (2017-04-24 22:26:06 UTC) #1
nodir
lgtm https://codereview.chromium.org/2836223002/diff/20001/appengine/components/components/auth/api.py File appengine/components/components/auth/api.py (right): https://codereview.chromium.org/2836223002/diff/20001/appengine/components/components/auth/api.py#newcode863 appengine/components/components/auth/api.py:863: if web_id: and not in additional_client_ids
3 years, 8 months ago (2017-04-24 22:34:24 UTC) #2
Vadim Sh.
https://codereview.chromium.org/2836223002/diff/20001/appengine/components/components/auth/api.py File appengine/components/components/auth/api.py (right): https://codereview.chromium.org/2836223002/diff/20001/appengine/components/components/auth/api.py#newcode863 appengine/components/components/auth/api.py:863: if web_id: On 2017/04/24 22:34:23, nodir wrote: > and ...
3 years, 8 months ago (2017-04-24 22:40:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836223002/20001
3 years, 8 months ago (2017-04-24 22:40:35 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 22:43:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/da04014d32632924f7256b27fa0235b727161e23

Powered by Google App Engine
This is Rietveld 408576698