Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2836143004: MD Settings: Allow empty passwords when importing certificate. (Closed)

Created:
3 years, 8 months ago by dpapad
Modified:
3 years, 8 months ago
Reviewers:
stevenjb
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org, Dan Beam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Allow empty passwords when importing certificate. BUG=714824 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2836143004 Cr-Commit-Position: refs/heads/master@{#466861} Committed: https://chromium.googlesource.com/chromium/src/+/6fcacd73cb3cca2e131fc8d94e3764744ecde23e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/resources/settings/certificate_manager_page/certificate_password_decryption_dialog.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/data/webui/settings/certificate_manager_page_test.js View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
dpapad
I'll ask on the bug on whether this needs to be merged.
3 years, 8 months ago (2017-04-25 00:40:52 UTC) #5
stevenjb
lgtm
3 years, 8 months ago (2017-04-25 00:44:31 UTC) #7
stevenjb
On 2017/04/25 00:40:52, dpapad wrote: > I'll ask on the bug on whether this needs ...
3 years, 8 months ago (2017-04-25 00:45:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836143004/1
3 years, 8 months ago (2017-04-25 01:19:39 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 01:40:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6fcacd73cb3cca2e131fc8d94e37...

Powered by Google App Engine
This is Rietveld 408576698