Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2836093006: Add a virtual destructor to PermissionPromptDelegate (Closed)

Created:
3 years, 7 months ago by raymes
Modified:
3 years, 7 months ago
Reviewers:
Timothy Loh
CC:
chromium-reviews, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a virtual destructor to PermissionPromptDelegate This is needed so that subclass destructors will be called when destroying a PermissionPromptDelegate pointer. This currently has no impact on behavior since there are no subclass destructors. BUG=596786 Review-Url: https://codereview.chromium.org/2836093006 Cr-Commit-Position: refs/heads/master@{#467617} Committed: https://chromium.googlesource.com/chromium/src/+/8c5be5dd012c0fd37a655748e561e5f8f92b6112

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/media/webrtc/media_stream_devices_controller.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
raymes
3 years, 7 months ago (2017-04-26 00:27:54 UTC) #6
Timothy Loh
On 2017/04/26 00:27:54, raymes wrote: lgtm
3 years, 7 months ago (2017-04-26 02:55:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836093006/1
3 years, 7 months ago (2017-04-27 06:42:32 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 07:29:25 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c5be5dd012c0fd37a655748e561...

Powered by Google App Engine
This is Rietveld 408576698