Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2836083003:
Use TaskScheduler instead of blocking pool in native_message_process_host.cc. (Closed)
DescriptionUse TaskScheduler instead of blocking pool in native_message_process_host.cc.
The blocking pool is being deprecated in favor of TaskScheduler.
BUG=667892
R=rdevlin.cronin@chromium.org
Review-Url: https://codereview.chromium.org/2836083003
Cr-Commit-Position: refs/heads/master@{#467663}
Committed: https://chromium.googlesource.com/chromium/src/+/77a3d68357be0360ccbc2177ce6ca75cd596646b
Patch Set 1 #
Total comments: 3
Patch Set 2 : USER_VISIBLE #Patch Set 3 : self-review #Messages
Total messages: 24 (16 generated)
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
PTAL! This CL was generated automatically. Please make sure that the appropriate TaskTraits are used to post tasks. https://cs.chromium.org/chromium/src/base/task_scheduler/task_traits.h If everything looks good, please lgtm and CQ this CL. Otherwise, tell us what's wrong. Thanks! - FAQ - What if bots are red? Ignore this CL. A human will look at errors shortly. What if the task priority is not set explicitly (no .WithTaskPriority())? When there is no explicit priority, the priority is inherited from the calling context (e.g. a task posted from a BACKGROUND task without an explicit priority will have a BACKGROUND priority). What if the shutdown behavior is not set explicitly (no .WithShutdownBehavior())? If shutdown behavior is important for a task, it should be set explicitly. It's not necessary to specify it if you're fine with either BLOCK_SHUTDOWN or SKIP_ON_SHUTDOWN.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
rdevlin.cronin@chromium.org changed reviewers: + sergeyu@chromium.org
+Sergey for native messaging knowledge, but my suspicion is this should be USER_VISIBLE. https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... File chrome/browser/extensions/api/messaging/native_message_process_host.cc (right): https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... chrome/browser/extensions/api/messaging/native_message_process_host.cc:151: .WithPriority(base::TaskPriority::BACKGROUND) This task can spawn a new process, which seems like it should be USER_VISIBLE.
https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... File chrome/browser/extensions/api/messaging/native_message_process_host.cc (right): https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... chrome/browser/extensions/api/messaging/native_message_process_host.cc:151: .WithPriority(base::TaskPriority::BACKGROUND) On 2017/04/24 20:22:11, Devlin wrote: > This task can spawn a new process, which seems like it should be USER_VISIBLE. Yes, this should be USER_VISIBLE. Depending on application that calls the API user may notice when there is a delay.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by fdoray@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Please take another look https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... File chrome/browser/extensions/api/messaging/native_message_process_host.cc (right): https://codereview.chromium.org/2836083003/diff/1/chrome/browser/extensions/a... chrome/browser/extensions/api/messaging/native_message_process_host.cc:151: .WithPriority(base::TaskPriority::BACKGROUND) On 2017/04/24 21:24:17, Sergey Ulanov wrote: > On 2017/04/24 20:22:11, Devlin wrote: > > This task can spawn a new process, which seems like it should be USER_VISIBLE. > > Yes, this should be USER_VISIBLE. Depending on application that calls the API > user may notice when there is a delay. Done.
lgtm
The CQ bit was checked by fdoray@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493301053553120,
"parent_rev": "4b1f1b0c63b6b65673c020d1f2b1177ce6619471", "commit_rev":
"77a3d68357be0360ccbc2177ce6ca75cd596646b"}
Message was sent while issue was closed.
Description was changed from ========== Use TaskScheduler instead of blocking pool in native_message_process_host.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rdevlin.cronin@chromium.org ========== to ========== Use TaskScheduler instead of blocking pool in native_message_process_host.cc. The blocking pool is being deprecated in favor of TaskScheduler. BUG=667892 R=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2836083003 Cr-Commit-Position: refs/heads/master@{#467663} Committed: https://chromium.googlesource.com/chromium/src/+/77a3d68357be0360ccbc2177ce6c... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/77a3d68357be0360ccbc2177ce6c... |
