Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(110)

Issue 2836063004: [webnfc] Nfc.push method must reject promise with TypeError (Closed)

Created:
2 years, 6 months ago by shalamov
Modified:
2 years, 6 months ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[webnfc] Nfc.push method must reject promise with TypeError According to latest changes in specification [1,2], when argument of invalid type is provided to nfc.push function, promise must be rejected with TypeError, instead of SyntaxError. [1] https://w3c.github.io/web-nfc/#dom-nfc-push [2] https://github.com/w3c/web-nfc/issues/110 BUG=714034 Review-Url: https://codereview.chromium.org/2836063004 Cr-Commit-Position: refs/heads/master@{#467258} Committed: https://chromium.googlesource.com/chromium/src/+/5f758d2372e693f69e1f3b1da495d95e5434e07f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/nfc/push.html View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/nfc/NFC.cpp View 2 chunks +17 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
shalamov
Please take a look.
2 years, 6 months ago (2017-04-25 15:48:36 UTC) #4
Reilly Grant (use Gerrit)
lgtm
2 years, 6 months ago (2017-04-25 19:46:05 UTC) #7
haraken
LGTM
2 years, 6 months ago (2017-04-26 01:31:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836063004/1
2 years, 6 months ago (2017-04-26 07:00:16 UTC) #10
commit-bot: I haz the power
2 years, 6 months ago (2017-04-26 07:06:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5f758d2372e693f69e1f3b1da495...

Powered by Google App Engine
This is Rietveld 408576698