Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 2836063002: Merge "cros: Fix race on feedback extension loading" (Closed)

Created:
3 years, 8 months ago by xiyuan
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "cros: Fix race on feedback extension loading" > - Move ExtensionHost check before loading feedback extension to fix the > race that ExtensionHost check could run after the loading makes > feedback background page up and running; > - Handle the case where feedkback background host already exists, > just in case. > - Add a retry in EnsureFeedbackUI to be sure the UI will be created; > > BUG=711123 > > Review-Url: https://codereview.chromium.org/2837613002 > Cr-Commit-Position: refs/heads/master@{#466395} > (cherry picked from commit 24d15b15c85b8d3a60c6985add50824fa6602467) Review-Url: https://codereview.chromium.org/2836063002 . Cr-Commit-Position: refs/branch-heads/3071@{#163} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/0afa4047734595061336ff666da0ed39ce9e5894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -13 lines) Patch
M chrome/browser/chromeos/login/ui/login_feedback.cc View 7 chunks +33 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 8 months ago (2017-04-24 15:55:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0afa4047734595061336ff666da0ed39ce9e5894.

Powered by Google App Engine
This is Rietveld 408576698