Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2836013005: Revert of Move vr features.gni into its own directory. (Closed)

Created:
3 years, 7 months ago by hcarmona
Modified:
3 years, 7 months ago
Reviewers:
mthiesse, agrieve
CC:
chromium-reviews, jam, feature-vr-reviews_chromium.org, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Move vr features.gni into its own directory. (patchset #1 id:1 of https://codereview.chromium.org/2840563004/ ) Reason for revert: Reverting to fix compile issue: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FLinux_x64%2F38350%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout fatal error: 'device/vr/features.h' file not found Original issue's description: > Move vr features.gni into its own directory. > > This fixes some weird issues we were encountering, where we had to hide some build targets behind (!is_ios) after adding our features target to ui/gfx. > I'm not sure if any extra code was being compiled in, but asserts in gn files were being hit related to things that shouldn't be included on ios. > It seems other features have already done this sort of thing. > > TBR=jochen@chromium.org > BUG= > > Review-Url: https://codereview.chromium.org/2840563004 > Cr-Commit-Position: refs/heads/master@{#467113} > Committed: https://chromium.googlesource.com/chromium/src/+/faae24707ba8852ea92b56bcf77aa19878aacdab TBR=agrieve@chromium.org,mthiesse@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2836013005 Cr-Commit-Position: refs/heads/master@{#467118} Committed: https://chromium.googlesource.com/chromium/src/+/ac414937946e8e50537698495b6eb8887875c453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/android/vr_shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/features.gni View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/BUILD.gn View 3 chunks +28 lines, -14 lines 0 comments Download
A device/vr/features.gni View 1 chunk +12 lines, -0 lines 0 comments Download
D device/vr/features/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D device/vr/features/features.gni View 1 chunk +0 lines, -12 lines 0 comments Download
M ui/gfx/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
hcarmona
Created Revert of Move vr features.gni into its own directory.
3 years, 7 months ago (2017-04-25 21:28:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836013005/1
3 years, 7 months ago (2017-04-25 21:29:06 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 21:30:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac414937946e8e50537698495b6e...

Powered by Google App Engine
This is Rietveld 408576698