VR: Fix crash when fallback font is missing

VR: Fix crash when fallback font is missing

BUG=715142
Review-Url: https://codereview.chromium.org/2836013004
Cr-Commit-Position: refs/heads/master@{#467033}
Committed: https://chromium.googlesource.com/chromium/src/+/7f2bb229d2728e932a8f50a881e792bfb803efc0

[mthiesse, 2017-04-25 16:32:55]

mthiesse@chromium.org changed reviewers:
+ cjgrant@chromium.org

[mthiesse, 2017-04-25 16:32:56]

PTAL

[cjgrant, 2017-04-25 16:40:06]

lgtm

https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textures/ui_texture.cc (right):

https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/ui_texture.cc:59: continue;
If we hit this, does it mean that some characters must render with the default
font?

[mthiesse, 2017-04-25 16:47:59]

https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textures/ui_texture.cc (right):

https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/ui_texture.cc:59: continue;
On 2017/04/25 16:40:06, cjgrant wrote:
> If we hit this, does it mean that some characters must render with the default
> font?

Yes, I'll add a TODO to address this when we move to gfx::GetFallbackFonts, as
we can't address it here.

[mthiesse, 2017-04-25 16:48:32]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-04-25 16:48:32]

The patchset sent to the CQ was uploaded after l-g-t-m from cjgrant@chromium.org
Link to the patchset: https://codereview.chromium.org/2836013004/#ps20001
(title: "add comment")

[commit-bot: I haz the power, 2017-04-25 16:48:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 17:22:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493138912519610,
"parent_rev": "ab0ddc886a06fa86fa53b77fde8c03fa07aad1e5", "commit_rev":
"7f2bb229d2728e932a8f50a881e792bfb803efc0"}

[commit-bot: I haz the power, 2017-04-25 17:22:30]

Description was changed from

==========
VR: Fix crash when fallback font is missing

BUG=715142
==========

to

==========
VR: Fix crash when fallback font is missing

BUG=715142

Review-Url: https://codereview.chromium.org/2836013004
Cr-Commit-Position: refs/heads/master@{#467033}
Committed:
https://chromium.googlesource.com/chromium/src/+/7f2bb229d2728e932a8f50a881e7...
==========

[commit-bot: I haz the power, 2017-04-25 17:22:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f2bb229d2728e932a8f50a881e7...