Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 2836013004: VR: Fix crash when fallback font is missing (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
cjgrant
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

VR: Fix crash when fallback font is missing BUG=715142 Review-Url: https://codereview.chromium.org/2836013004 Cr-Commit-Position: refs/heads/master@{#467033} Committed: https://chromium.googlesource.com/chromium/src/+/7f2bb229d2728e932a8f50a881e792bfb803efc0

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/android/vr_shell/textures/ui_texture.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
mthiesse
PTAL
3 years, 7 months ago (2017-04-25 16:32:56 UTC) #2
cjgrant
lgtm https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_shell/textures/ui_texture.cc File chrome/browser/android/vr_shell/textures/ui_texture.cc (right): https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_shell/textures/ui_texture.cc#newcode59 chrome/browser/android/vr_shell/textures/ui_texture.cc:59: continue; If we hit this, does it mean ...
3 years, 7 months ago (2017-04-25 16:40:06 UTC) #3
mthiesse
https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_shell/textures/ui_texture.cc File chrome/browser/android/vr_shell/textures/ui_texture.cc (right): https://codereview.chromium.org/2836013004/diff/1/chrome/browser/android/vr_shell/textures/ui_texture.cc#newcode59 chrome/browser/android/vr_shell/textures/ui_texture.cc:59: continue; On 2017/04/25 16:40:06, cjgrant wrote: > If we ...
3 years, 7 months ago (2017-04-25 16:47:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836013004/20001
3 years, 7 months ago (2017-04-25 16:48:49 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-04-25 17:22:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f2bb229d2728e932a8f50a881e7...

Powered by Google App Engine
This is Rietveld 408576698