Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2836013003: [heap] Filter out nullptr when registering externally referenced objects (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Filter out nullptr when registering externally referenced objects Ideally they are already filtered on the embedder side. Sometimes howevever, embedders end up with a Local<T> pointing to a nullptr object. In this case the best way to filter this is right at the beginning of the registration process. BUG=chromium:713667 Review-Url: https://codereview.chromium.org/2836013003 Cr-Commit-Position: refs/heads/master@{#44844} Committed: https://chromium.googlesource.com/v8/v8/+/64e06641ebeef8bf86174c9465b5dbc002d73ca4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/heap/heap.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (8 generated)
Hannes Payer (out of office)
lgtm
3 years, 8 months ago (2017-04-25 11:18:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2836013003/1
3 years, 8 months ago (2017-04-25 11:46:13 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 11:47:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/64e06641ebeef8bf86174c9465b5dbc002d...

Powered by Google App Engine
This is Rietveld 408576698