Remove WeakPtrFactory from LayerAnimationSequence

Remove WeakPtrFactory from LayerAnimationSequence

LayerAnimationSequence already inherits SupportsWeakPtr.
Hence, instead of creating a WeakPtrFactory instance to
access its weak pointer, we can directly use AsWeakPtr().

BUG=None

Review-Url: https://codereview.chromium.org/2835983003
Cr-Commit-Position: refs/heads/master@{#466682}
Committed: https://chromium.googlesource.com/chromium/src/+/a6eeba23df5cfb221d5b82326d544762aacd83ff

[Chandan, 2017-04-24 12:41:21]

c.padhi@samsung.com changed reviewers:
+ ajuma@chromium.org, loyso@chromium.org

[Chandan, 2017-04-24 12:41:22]

PTAL. Thank you.

[ajuma, 2017-04-24 13:13:51]

lgtm

[Chandan, 2017-04-24 13:25:12]

The CQ bit was checked by c.padhi@samsung.com

[commit-bot: I haz the power, 2017-04-24 13:25:29]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 14:45:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 14:45:28]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Chandan, 2017-04-24 16:16:31]

On 2017/04/24 14:45:28, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

org.chromium.chrome.browser.CopylessPasteTest#testNoMeta has failed.
java.util.concurrent.TimeoutException: waitForCallback timed out!
	at
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
	at
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:219)
	at
org.chromium.chrome.browser.CopylessPasteTest.testNoMeta(CopylessPasteTest.java:130)
As per the description in CallbackHelper.java for waitForCallback(),
TimeoutException is thrown if the method times out before onPageFinished is
called.
I am wondering how this failure is caused by or related to this CL.
ajuma@ your inputs please.

[ajuma, 2017-04-24 17:19:47]

On 2017/04/24 16:16:31, Chandan wrote:
> On 2017/04/24 14:45:28, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> 
> org.chromium.chrome.browser.CopylessPasteTest#testNoMeta has failed.
> java.util.concurrent.TimeoutException: waitForCallback timed out!
> 	at
>
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:183)
> 	at
>
org.chromium.base.test.util.CallbackHelper.waitForCallback(CallbackHelper.java:219)
> 	at
>
org.chromium.chrome.browser.CopylessPasteTest.testNoMeta(CopylessPasteTest.java:130)
> As per the description in CallbackHelper.java for waitForCallback(),
> TimeoutException is thrown if the method times out before onPageFinished is
> called.
> I am wondering how this failure is caused by or related to this CL.
> ajuma@ your inputs please.

It looks like an unrelated failure, go ahead and try to commit again.

[Chandan, 2017-04-24 17:26:37]

The CQ bit was checked by c.padhi@samsung.com

[commit-bot: I haz the power, 2017-04-24 17:27:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:08:47]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493054797672960, "parent_rev":
"8f8f7d30276c21106db2b65f176e999b592549ea", "commit_rev":
"a6eeba23df5cfb221d5b82326d544762aacd83ff"}

[commit-bot: I haz the power, 2017-04-24 18:09:00]

Description was changed from

==========
Remove WeakPtrFactory from LayerAnimationSequence

LayerAnimationSequence already inherits SupportsWeakPtr.
Hence, instead of creating a WeakPtrFactory instance to
access its weak pointer, we can directly use AsWeakPtr().

BUG=None
==========

to

==========
Remove WeakPtrFactory from LayerAnimationSequence

LayerAnimationSequence already inherits SupportsWeakPtr.
Hence, instead of creating a WeakPtrFactory instance to
access its weak pointer, we can directly use AsWeakPtr().

BUG=None

Review-Url: https://codereview.chromium.org/2835983003
Cr-Commit-Position: refs/heads/master@{#466682}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6eeba23df5cfb221d5b82326d54...
==========

[commit-bot: I haz the power, 2017-04-24 18:09:01]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a6eeba23df5cfb221d5b82326d54...