Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2835933007:
MD Settings: show when the default search engine is controlled by policy (Closed)
|
Created:
3 years, 8 months ago by Dan Beam Modified:
3 years, 8 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: show when the default search engine is controlled by policy
R=dpapad@chromium.org
BUG=711063
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2835933007
Cr-Commit-Position: refs/heads/master@{#467476}
Committed: https://chromium.googlesource.com/chromium/src/+/0e5bf385b3882b6a124ace5495c957e735b5ffcc
Patch Set 1 #Patch Set 2 : appease closure #Patch Set 3 : merge #
Total comments: 2
Patch Set 4 : fix typo, dpapad@ review #
Messages
Total messages: 33 (25 generated)
Description was changed from ========== MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG=711063 ========== to ========== MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG=711063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Can we add a test to check that the proper UI is displayed when the search engine is controlled by policy? We already have a test for the "controlled by extension" case at https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_p....
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/25 17:14:24, dpapad wrote: > Can we add a test to check that the proper UI is displayed when the search > engine is controlled by policy? We already have a test for the "controlled by > extension" case at > https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/search_p.... Done.
Patchset #3 (id:40001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:60001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM https://codereview.chromium.org/2835933007/diff/80001/chrome/browser/resource... File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/2835933007/diff/80001/chrome/browser/resource... chrome/browser/resources/settings/search_page/search_page.html:47: <cr-policy-pref-indicator pref="[[ Let's add an HTML import for cr_policy_pref_indicator.html in this file.
https://codereview.chromium.org/2835933007/diff/80001/chrome/browser/resource... File chrome/browser/resources/settings/search_page/search_page.html (right): https://codereview.chromium.org/2835933007/diff/80001/chrome/browser/resource... chrome/browser/resources/settings/search_page/search_page.html:47: <cr-policy-pref-indicator pref="[[ On 2017/04/26 17:27:05, dpapad wrote: > Let's add an HTML import for cr_policy_pref_indicator.html in this file. Done.
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2835933007/#ps100001 (title: "fix typo, dpapad@ review")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493239273624540,
"parent_rev": "7902e09852f047a487122472800d482fd28e6b7c", "commit_rev":
"0e5bf385b3882b6a124ace5495c957e735b5ffcc"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG=711063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG=711063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2835933007 Cr-Commit-Position: refs/heads/master@{#467476} Committed: https://chromium.googlesource.com/chromium/src/+/0e5bf385b3882b6a124ace5495c9... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as https://chromium.googlesource.com/chromium/src/+/0e5bf385b3882b6a124ace5495c9... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
