Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2835923004: [Ic-Processor] Let us know if an IC is in opt. or unopt. code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 4 weeks ago by mvstanton
Modified:
5 months, 4 weeks ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[Ic-Processor] Let us know if an IC is in opt. or unopt. code. Traditionally, we had a prefix for a function name of "~" for unoptimized code and "*" for optimized code. Restore this prefix in v8/tools/ic-processor. It's really cool to know if an IC was called from optimized code (often a hint of poor performance!). NOTRY=true R=cbruni@chromium.org Review-Url: https://codereview.chromium.org/2835923004 Cr-Commit-Position: refs/heads/master@{#44846} Committed: https://chromium.googlesource.com/v8/v8/+/278688135f77ad8a51e45e99d60a6e8ba65844e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M tools/ic-processor.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/profile.js View 1 chunk +8 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 8 (4 generated)
mvstanton
Hi Camillo, per our discussion, thanks for the look! --Michael
5 months, 4 weeks ago (2017-04-25 10:33:53 UTC) #1
Camillo Bruni
lgtm
5 months, 4 weeks ago (2017-04-25 11:28:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835923004/1
5 months, 4 weeks ago (2017-04-25 12:00:04 UTC) #5
commit-bot: I haz the power
5 months, 4 weeks ago (2017-04-25 12:01:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/278688135f77ad8a51e45e99d60a6e8ba65...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa