Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2835923002: Don't show the Location Settings Dialog if the tab isn't interactable. (Closed)

Created:
3 years, 8 months ago by benwells
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't show the Location Settings Dialog if the tab isn't interactable. If the tab for the web_contents that requested location isn't interactable, the Location Settings Dialog shouldn't be shown. This could happen if the user changed tabs, is in the tab switcher, or if Chrome isn't active. BUG=710255 Review-Url: https://codereview.chromium.org/2817873002 Cr-Commit-Position: refs/heads/master@{#465795} (cherry picked from commit b8a8a089caa1188776c83e4344df494d6f30b969) Review-Url: https://codereview.chromium.org/2835923002 . Cr-Commit-Position: refs/branch-heads/3071@{#156} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/196648220d843aa53efaf3f123ba49476f3f2f8c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/browser/geolocation/geolocation_permission_context_android.cc View 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
benwells
3 years, 8 months ago (2017-04-24 07:13:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
196648220d843aa53efaf3f123ba49476f3f2f8c.

Powered by Google App Engine
This is Rietveld 408576698