Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2835903004: [Telemetry] Refactor a Loading benchmark base class. (Closed)

Created:
3 years, 8 months ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, kouhei (in TOK), Kunihiko Sakamoto
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Refactor a Loading benchmark base class. This work is to help with the creation of loading.desktop benchmarks. BUG=713346 Review-Url: https://codereview.chromium.org/2835903004 Cr-Commit-Position: refs/heads/master@{#466822} Committed: https://chromium.googlesource.com/chromium/src/+/8b2c1f9d654df94508218898117d4cdf20f11159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M tools/perf/benchmarks/loading.py View 3 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
rnephew (Reviews Here)
3 years, 8 months ago (2017-04-24 21:45:08 UTC) #3
nednguyen
lgtm
3 years, 8 months ago (2017-04-24 22:09:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2835903004/20001
3 years, 8 months ago (2017-04-24 22:18:04 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 23:30:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b2c1f9d654df94508218898117d...

Powered by Google App Engine
This is Rietveld 408576698